-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollouts: scripts and dev guide for running with kind #3888
Conversation
d375576
to
0f237a2
Compare
0f237a2
to
36f1092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have some minor suggestions.
rollouts/Makefile
Outdated
.PHONY: run-in-kind | ||
run-in-kind: manifests kustomize ## Run the rollouts-controller-manager in a kind cluster named rollouts-management-cluster | ||
kind delete cluster --name=rollouts-management-cluster | ||
kind create cluster --name=rollouts-management-cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion: we should invoke these commands with a kubeconfig location to avoid manipulating the default kubectl
context. And then use KUBECONFIG=/path/to/kubeconfig/mgmt-cluster kubectl ...
format for all the commands.
And we can use a standard directory path say .tests/kube/
and also add that path to .gitignore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to use ~/.kube/admin-cluster
because that's what we did in the guide for running the admin cluster with config-controller.
verbs: | ||
- get | ||
- list | ||
- watch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this: I completely missed these.
072d4a4
to
8ba3467
Compare
This PR adds make targets for developing rollouts with
Kind
, and updates the dev guide to add instructions for development with kind.Fixes #3887